fixed watch not working when NODE_ENV is production #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Sep 17, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
--- name: 馃檵 fix for watch not working when NODE_ENV is 'production' about: fixes issue #2011 --- <!--- Thanks for filing a pull request 馃槃 ! Before you submit, please read the following: Search open/closed issues before submitting since someone might have pushed the same thing before! --> ## 鈫笍 Pull Request <!--- Provide a general summary of the pull request here Does this address an existing issue? --> I understand that Parcel should watch changes every time the watch command is being used. Previously, watch was enabled on dev environment only, while the watch command inserted by users was completely ignored. With this modification, watch is always enabled if the user passes the command in CLI. ## 馃捇 Examples There is an example in #2011 - first post ## 鉁旓笍 PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [ ] Included links to related issues/PRs <!-- Love parcel? Please consider supporting our collective: 馃憠 https://opencollective.com/parcel/donate -->
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
--- name: 馃檵 fix for watch not working when NODE_ENV is 'production' about: fixes issue #2011 --- <!--- Thanks for filing a pull request 馃槃 ! Before you submit, please read the following: Search open/closed issues before submitting since someone might have pushed the same thing before! --> ## 鈫笍 Pull Request <!--- Provide a general summary of the pull request here Does this address an existing issue? --> I understand that Parcel should watch changes every time the watch command is being used. Previously, watch was enabled on dev environment only, while the watch command inserted by users was completely ignored. With this modification, watch is always enabled if the user passes the command in CLI. ## 馃捇 Examples There is an example in #2011 - first post ## 鉁旓笍 PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [ ] Included links to related issues/PRs <!-- Love parcel? Please consider supporting our collective: 馃憠 https://opencollective.com/parcel/donate -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 馃檵 fix for watch not working when NODE_ENV is 'production'
about: fixes issue #2011
鈫笍 Pull Request
I understand that Parcel should watch changes every time the watch command is being used.
Previously, watch was enabled on dev environment only, while the watch command inserted by users was completely ignored.
With this modification, watch is always enabled if the user passes the command in CLI.
馃捇 Examples
There is an example in #2011 - first post
鉁旓笍 PR Todo